o/snapstate, o/devicestate: remodel with components from the store #14933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewphelpsj
force-pushed
the
remodel-components-from-store
branch
from
fb52d67 to
7e4bd1c
Compare
|
Thu Jan 16 21:32:29 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
andrewphelpsj
force-pushed
the
remodel-components-from-store
branch
from
7e4bd1c to
9d70ca3
Compare
…mponent-setup when installing a snap with components This indicates to ifacestate's setup-profiles handler that the setup-profiles should operate on a snap and a set of components, rather than a single component.
…s only associated with components or not
…used to create a recovery system
andrewphelpsj
force-pushed
the
remodel-components-from-store
branch
from
9d70ca3 to
f291bf0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14933 +/- ##
=========================================
Coverage ? 78.12%
=========================================
Files ? 1159
Lines ? 153588
Branches ? 0
=========================================
Hits ? 119993
Misses ? 26192
Partials ? 7403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewphelpsj
commented
Jan 17, 2025
| snapsupTask = t | ||
| break | ||
| } | ||
| t := ts.MaybeEdge(snapstate.SnapSetupEdge) |
There was a problem hiding this comment.
@pedronis here is where the new edge is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables us to do a remodel that includes components from the store. This is a little incomplete, as I discovered that I need to handle the case where we swap to an already installed kernel (leftover from a previous remodeling) that may have some components already installed. This is a small edge case, and will not change most of the PR.
Based on #14939 for now.